Discover Centmin Mod today
Register Now

Wordpress Wordpress jQuery1.12.4 Vulnerability

Discussion in 'Blogs & CMS usage' started by EckyBrazzz, May 8, 2019.

  1. Remzi

    Remzi New Member

    8
    4
    3
    Jul 2, 2019
    Amsterdam, The Netherlands
    Ratings:
    +5
    Local Time:
    2:02 PM
    I have merged your pull request. You have also push access to the repo, please be careful.

    See some reading on the git model working in teams:
    - A successful Git branching model
    - Gitflow Workflow | Atlassian Git Tutorial
    - Understanding the GitHub flow · GitHub Guides

    Basically, the master branch is the stable / production branch. This branch should be production ready and stable code. The develop branch is where the development of new features should take place and every new feature or fix should be a new / different branch and eventually merge back to develop or master. After merging the fix-name or feature-name branch could be deleted/removed.

    This is a small project, so I don't thing we need a lot of branches.


    So basically / in summary
    We have these branches:

    - master (stable / production)
    - develop (new builds / testing)
    - feature or fix branches (temporary branches deleted after merging back to master or develop)
     
    Last edited: Jul 2, 2019
  2. eva2000

    eva2000 Administrator Staff Member

    51,696
    11,941
    113
    May 24, 2014
    Brisbane, Australia
    Ratings:
    +18,432
    Local Time:
    10:02 PM
    Nginx 1.25.x
    MariaDB 10.x
    cheers understood - will try my best not to screw things up :LOL::D

    probably I'll end up in feature/fix branches work space mainly :)
     
  3. Remzi

    Remzi New Member

    8
    4
    3
    Jul 2, 2019
    Amsterdam, The Netherlands
    Ratings:
    +5
    Local Time:
    2:02 PM
    Hi @eva2000

    Could you remove your forked version from centminmod and provide the official wp.org plugin version? (jQuery Manager for WordPress)
    This way we could provide better support ;)

    I see on wp.org statics (jQuery Manager for WordPress) that around 32% are using an outdated version (1.7.x)

    This plugin could get some GitHub love, you guys could starred it :):D Also from you @EckyBrazzz (y)
     
    Last edited: Jul 4, 2019
  4. eva2000

    eva2000 Administrator Staff Member

    51,696
    11,941
    113
    May 24, 2014
    Brisbane, Australia
    Ratings:
    +18,432
    Local Time:
    10:02 PM
    Nginx 1.25.x
    MariaDB 10.x
    no one really uses my forked version so 1.7* would not be from my fork heh. But yeah I'll remove it as it's been broken ever since you switched to wordpress.org plugin update system anyway :)
     
  5. EckyBrazzz

    EckyBrazzz Active Member

    916
    189
    43
    Mar 28, 2018
    >>>>Click here<<<< i'm nearby......
    Ratings:
    +362
    Local Time:
    9:02 AM
    Latest
    Latest
    @Remzi Job done at WordPress. It's only been held for moderation. Glad I gave you a wake up call at GitHub a time ago;)

     
    Last edited: Jul 4, 2019
  6. Remzi

    Remzi New Member

    8
    4
    3
    Jul 2, 2019
    Amsterdam, The Netherlands
    Ratings:
    +5
    Local Time:
    2:02 PM
    @EckyBrazzz yeah, I'm glad as well. I didn't know my plugin was outdated. Now it's an official WP plugin :D

    EDIT: @eva2000 Will this plugin be included as default on the Centmin Mod WordPress installer? At our company (at the moment I work for a lead generation agency) we use a custom WP installer with the default themes, plugins, example pages and example posts removed. We also include this plugin and other plugins we use.
     
    Last edited: Jul 4, 2019