Join the community today
Become a Member

Beta Branch update nginx 1.23.0 default in 130.00beta01

Discussion in 'Centmin Mod Github Commits' started by eva2000, Jun 22, 2022.

  1. eva2000

    eva2000 Administrator Staff Member

    49,291
    11,295
    113
    May 24, 2014
    Brisbane, Australia
    Ratings:
    +17,574
    Local Time:
    4:26 AM
    Nginx 1.21.x
    MariaDB 10.x
  2. pamamolf

    pamamolf Premium Member Premium Member

    3,991
    416
    83
    May 31, 2014
    Ratings:
    +806
    Local Time:
    9:26 PM
    Nginx-1.17.x
    MariaDB 10.3.x
    Hi :)

    When i tried i got:

    Code:
    Note: As at June 22, 2022 Nginx 1.23.0 is incompatible with several
    Centmin Mod Nginx modules like srcache-nginx-module & redis nginx module
    until then, you can stick with 1.21.6.
    I run first cmupdate and i am on: 130.00beta01

    Thanks
     
  3. eva2000

    eva2000 Administrator Staff Member

    49,291
    11,295
    113
    May 24, 2014
    Brisbane, Australia
    Ratings:
    +17,574
    Local Time:
    4:26 AM
    Nginx 1.21.x
    MariaDB 10.x
  4. buik

    buik “The best traveler is one without a camera.”

    1,731
    472
    83
    Apr 29, 2016
    Flanders
    Ratings:
    +1,482
    Local Time:
    8:26 PM
    The last update of the srcache-nginx-module is 4 years ago.
    Fortunately, I don't use this plugin. The question is whether it will be updated at all.
     
  5. eva2000

    eva2000 Administrator Staff Member

    49,291
    11,295
    113
    May 24, 2014
    Brisbane, Australia
    Ratings:
    +17,574
    Local Time:
    4:26 AM
    Nginx 1.21.x
    MariaDB 10.x
    Yeah the OpenResty developed srcache-nginx-module hasn't been updated in a while but that can also be because it doesn't need updating until now. This module is used for Centmin Mod's centmin.sh menu option 22 Wordpress auto installer's guest full HTML page caching using Redis Nginx level caching.

    I submitted issue for srcache-nginx-module at Nginx 1.23.0 header changes · Issue #96 · openresty/srcache-nginx-module and seems there's a PR for it already Update handling of cache_control changed in nginx 1.23.0 (Fixes #96) by hnakamur · Pull Request #97 · openresty/srcache-nginx-module :)

    1.23.0 also breaks the nginx redis module also used by Centmin Mod's centmin.sh menu option 22 Wordpress auto installer's guest full HTML page caching using Redis Nginx level caching and have issue posted at nginx 1.23.0 header changes · Issue #1 · osokin/ngx_http_redis

    1.23.0 also needs optional Nginx njs module update to 0.7.5 so once 1.23.0 compatibility is fixed, I'd need to update Nginx njs module to 0.7.5 as well njs scripting language :)

    Looks like OpenResy headers-more nginx module also needs update for 1.23.0 headers-more-nginx-module not compatible with nginx 1.23.0 · Issue #132 · openresty/headers-more-nginx-module

    I get
    Code (Text):
    In file included from /usr/include/dlfcn.h:25,
                     from src/os/unix/ngx_linux_config.h:58,
                     from src/core/ngx_config.h:26,
                     from ../headers-more-nginx-module-0.33/src/ddebug.h:5,
                     from ../headers-more-nginx-module-0.33/src/ngx_http_headers_more_headers_in.c:10:
    ../headers-more-nginx-module-0.33/src/ngx_http_headers_more_headers_in.c:162:50: error: ‘ngx_http_headers_in_t’ has no member named ‘cookies’; did you mean ‘cookie’?
      162 |                  offsetof(ngx_http_headers_in_t, cookies),
          |                                                  ^~~~~~~
    make[1]: *** [objs/Makefile:2857: objs/addon/src/ngx_http_headers_more_headers_in.o] Error 1
    make[1]: *** Waiting for unfinished jobs....
    make[1]: Leaving directory '/svr-setup/nginx-1.23.0'
    make: *** [Makefile:10: build] Error 2
    
     
    Last edited: Jun 22, 2022
  6. buik

    buik “The best traveler is one without a camera.”

    1,731
    472
    83
    Apr 29, 2016
    Flanders
    Ratings:
    +1,482
    Local Time:
    8:26 PM
  7. eva2000

    eva2000 Administrator Staff Member

    49,291
    11,295
    113
    May 24, 2014
    Brisbane, Australia
    Ratings:
    +17,574
    Local Time:
    4:26 AM
    Nginx 1.21.x
    MariaDB 10.x
    There's pull request fixes for headers-more and srcache already, I have them auto patched on latest Centmin Mod 130.00beta01 update. But waiting on ngx_http_redis. Reminds me also need to do the same for 124.00stable.
     
  8. runos

    runos Member

    46
    16
    8
    Dec 17, 2019
    Ratings:
    +19
    Local Time:
    2:26 AM
    1.17.6
    10
    Oh man.. my whole server down after updating to 1.23.0
    I recall I was running 1.22.0 before this.
    Downgrading now.

    If it still fail, will downgrade to 1.21.6 as suggested by admin :)

    Lesson learned. Do not upgrade too fast and wait for admin announcement next time.

    * UPDATE:
    Just confirmed 1.22.0 working
     
    Last edited: Jun 23, 2022
  9. buik

    buik “The best traveler is one without a camera.”

    1,731
    472
    83
    Apr 29, 2016
    Flanders
    Ratings:
    +1,482
    Local Time:
    8:26 PM
    Yeah i don't like the fact that Centminmod is semi blocking the new Nginx 1.23 because of some old Redis module. But that's also partly down to me. I'm of the less is more principle.
     
  10. eva2000

    eva2000 Administrator Staff Member

    49,291
    11,295
    113
    May 24, 2014
    Brisbane, Australia
    Ratings:
    +17,574
    Local Time:
    4:26 AM
    Nginx 1.21.x
    MariaDB 10.x
    Yeah 1.21.6 and 1.22.0 branches should work.

    Yeah didn't want to but better than potentially breaking all Centmin Mod users Nginx install/configs. Only a small fraction of Centmin Mod users frequent the forums so wouldn't know about the issue. Then again realistically not much will break as a failed 1.23 update will just use existing Nginx running binary without issue just you won't successfully update to Nginx 1.23.0 without fixing module compatibility.

    FYI, I actively use all the incompatible Nginx modules - headers more, srcache, redis and also Nginx njs modules :)
     
  11. runos

    runos Member

    46
    16
    8
    Dec 17, 2019
    Ratings:
    +19
    Local Time:
    2:26 AM
    1.17.6
    10
    How important is this update security wise? This seems to be a big update so if possible, I would just wait for few more weeks before updating for the community to iron out any other server crashing bugs :)
     
  12. buik

    buik “The best traveler is one without a camera.”

    1,731
    472
    83
    Apr 29, 2016
    Flanders
    Ratings:
    +1,482
    Local Time:
    8:26 PM
    We also need to review this for the longer term.
    There are modules on your list that are non-maintained up to 5 years.

    This is going to cause a lot more problems in the near future because Nginx keeps changing too. And soon with HTTP/3, Nginx is going to have major changes altogether.
     
  13. eva2000

    eva2000 Administrator Staff Member

    49,291
    11,295
    113
    May 24, 2014
    Brisbane, Australia
    Ratings:
    +17,574
    Local Time:
    4:26 AM
    Nginx 1.21.x
    MariaDB 10.x
    There's no real security update, 1.23.0 mainline is based off of 1.21.x mainline which Centmin Mod Nginx 1.21.6 is using. You can see change log of mainline at https://nginx.org/en/CHANGES it goes from 1.21.6 to 1.23.0 and only changes in 1.23.0 from 1.21.6 are bug fixes and changes to header handling (which is what broke other nginx modules compatibility)
     
  14. eva2000

    eva2000 Administrator Staff Member

    49,291
    11,295
    113
    May 24, 2014
    Brisbane, Australia
    Ratings:
    +17,574
    Local Time:
    4:26 AM
    Nginx 1.21.x
    MariaDB 10.x
    Yes definitely on my mind always! Hence why I have a stable and beta version and why a lot of Nginx modules are controlled by individual variables you can turn on/off via persistent config file so Centmin Mod so can cater to different users.

    Though the redis nginx module is hard coded to enable due to Centmin Mod centmin.sh menu option 22 Wordpress installer offering Redis Nginx level caching method as a selection option. I guess I can add a check to hide that selection as a choice, if redis nginx module is disabled by end user. Going to add that feature into 130.00beta01 soon :)
     
  15. buik

    buik “The best traveler is one without a camera.”

    1,731
    472
    83
    Apr 29, 2016
    Flanders
    Ratings:
    +1,482
    Local Time:
    8:26 PM
    I don't like Redis as it adds lots of extra code to Nginx and Wordpress (in case of option 22) with also the use of extra plugins.