sshd_config bug

Hi,

I had an issue where a fresh install of 123.08stable is locking me out. At first I thought it was a CSF issue. So, I started 2 ssh sessions logged out of one and could not log back in even with a white listed IP. So I checked ssh and it was dead (still allowing a ssh connection started before install). My /etc/ssh/sshd_config had this at the bottom:

Example 1.

UseDNS noClientAliveInterval 3600
ClientAliveCountMax 120
UseDNS no
​

When it should have been this:

Example 2.

ClientAliveInterval 3600
ClientAliveCountMax 120
UseDNS no
​

I started a new fresh install on a newly launched EC2 and inspected sshd_config before firing up the install and it was fine. After the install sshd_config had the new directives appended to an existing line as in example 1.

---

In inc/sshd.inc the following:

if [[ -z "$CHECKVALUES" ]]; then
echo "ClientAliveInterval 3600" >> /etc/ssh/sshd_config
echo "ClientAliveCountMax 120" >> /etc/ssh/sshd_config
echo "UseDNS no" >> /etc/ssh/sshd_config
#echo "ServerAliveInterval 120" >> /etc/ssh/sshd_config
#echo "ServerAliveCountMax 120" >> /etc/ssh/sshd_config
fi

Change to
if [[ -z "$CHECKVALUES" ]]; then
echo -e "\n \n" >> /etc/ssh/sshd_config
echo "ClientAliveInterval 3600" >> /etc/ssh/sshd_config
echo "ClientAliveCountMax 120" >> /etc/ssh/sshd_config
echo "UseDNS no" >> /etc/ssh/sshd_config
#echo "ServerAliveInterval 120" >> /etc/ssh/sshd_config
#echo "ServerAliveCountMax 120" >> /etc/ssh/sshd_config
fi
I haven't run this but I think it will do the trick.

BR,
Sean

P.S. This is on AWS.

Also, I read that on the CSF page that OpenVZ does not support ipset. Just wanted to let you know that it appears to be running.

​