Redirects

What do you think about adding to 2 and 22 redirect options? I think that it is often necessary to do this operation manually now.

---

For example https-www-redirect:

Code (Text):

server {
    server_name %domain% www.%domain%;

    # turn off HSTS and browsers do not use 307 redirect
    # BUT we have "man-in-the-middle" attack
    #add_header Strict-Transport-Security "max-age=0; includeSubDomains";

    return 301 https://www.%domain%$request_uri;
}

server {
    listen 443 ssl http2;
    server_name %domain%;

    return 301 https://www.%domain%$request_uri;

    ssl_dhparam         /usr/local/nginx/conf/ssl/%domain%/dhparam.pem;
    ssl_certificate     /usr/local/nginx/conf/ssl/%domain%/%domain%.crt;
    ssl_certificate_key /usr/local/nginx/conf/ssl/%domain%/%domain%.key;
    include             /usr/local/nginx/conf/ssl_include.conf;
}

and change %domain%.ssl.conf:

Code (Text):

    server_name www.%domain%;

 

Yes, it's sad. So it is nice to have options for various installations. I like bash, but the automatic installation liked more.

 

Do you use templates for creat confs?

 

I understand. Therefore, I try to use the connection point *.conf

Code (Text):

%domain%.<some_action>.conf

It would be good to use %domain%*.conf in remove scripts and connection point (/usr/local/nginx/conf/inc/%domain%/*.inc) in %domain%.conf and %domain%.ssl.conf:

Code (Text):

include /usr/local/nginx/conf/inc/%domain%/*.inc;

 

Ok.
I am newbie and I have not read your code carefully.

 

What do you think about adding

Code (Text):

include /usr/local/nginx/conf/inc/${vhostname}/*.inc;

in ${vhostname}.conf and ${vhostname}.ssl.conf?

 

Top of the conf is the best place, but it can appear many user errors. Therefore, the bottom of the conf is a good place.

 

Edit conf is not a good practice. Include can correct the situation. It is the second point as *.conf.

And during installation, after the question

Code (Text):

Enter vhost domain name you want to add (without www. prefix):

need a question:

Code (Text):

Add www.${vhostname} site? (y/n)

Now we do not need to edit confs.

 

change-the-default-site.sh?

 

I have read this manual. I do not like this code:

Code (Text):

   ##  redirect https www to https non-www
      if ($host = 'www.mydomain.com' ) {
         return 302 https://mydomain.com$request_uri;
      }

You use it, because you have:

Code (Text):

server_name newdomain.com www.newdomain.com;

if is imperative code. Nginx in general is declarative.
Maybe I'm wrong, but this code is better and faster:

Code (Text):

server {listen 443 ssl http2; server_name newdomain.com;}
server {listen 443 ssl http2; server_name www.newdomain.com; return 301 https://newdomain.com$request_uri;}

Probably possible to use a stubs (server-section) and "conf-disable". I should think.

 

I agree that this is not an easy task. You're doing it right. I test acmetool.sh and see that it parses сonf. Hard work. I try use:

Code (Text):

#./acmetool.sh issue domain.tld,www.domain.tld live
...
/root/.acme.sh/acme.sh --issue -d domain.tld -d www.domain.tld -d www.domain.tld ...

Result:

Code (Text):

server_name domain.tld www.domain.tld www.domain.tld;

No problem, I removed the double-www manually. Parsing is always difficult to test.
May be use 1 domain in server section? Then there will be 4 (or to 2 if www do not needed) confs, which can be replaced by any redirects files without parsing.