Discover Centmin Mod today
Register Now

Beta Branch skip obsolete AWS-LC compatibility patches on nginx 1.29.2+ in 140.00…

Discussion in 'Centmin Mod Github Commits' started by eva2000, Jul 26, 2026 at 7:14 AM.

  1. eva2000

    eva2000 Administrator Staff Member

    59,307
    12,510
    113
    May 24, 2014
    Brisbane, Australia
    Ratings:
    +19,143
    Local Time:
    9:06 PM
    Nginx 1.31.x
    MariaDB 10.x/11.4+/12.3+
    skip obsolete AWS-LC compatibility patches on nginx 1.29.2+ in 140.00beta01

    nginx gained native AWS-LC support in 1.29.2 via upstream commit 93ff1ee1
    "SSL: AWS-LC compatibility", so the bundled compatibility patches are no
    longer needed. Upstream added OPENSSL_IS_AWSLC to the src/event/quic/*
    sources only, never to src/event/ngx_event_openssl.c or .h, so the greps
    guarding the patch arms could not detect it and the patch was applied
    anyway - every hunk fails against 1.29.2+ because upstream already made
    the same changes. Verified by dry-run against nginx 1.31.3: 18 of 18
    hunks fail for aws-lc-nginx-1.28.0.patch and 19 of 19 for
    aws-lc-nginx.patch, while aws-lc-nginx2.patch still applies cleanly.


    AWS-LC also removed both patches from its repo, so the fallback download
    returned a 404 HTML error page which was then fed to patch.

    Changes:
    - skip the compatibility patches when DETECT_NGXVER is 1.29.2 or newer
    - keep applying aws-lc-nginx2.patch on all versions as the $ssl_curve
    support is a Centmin Mod addition, not an upstream compatibility shim
    - add curl -f and remove the partial file so a dead download no longer
    reaches patch, and report patch failures instead of silently continuing
    - drop aws_lc_patch_make and its AWS_LC_SWITCH_TEST variable as the test
    suite patch it applied was removed upstream and its target file lives
    in the separate nginx-tests repo, not the nginx source tree

    Continue reading...

    140.00beta01 branch