Learn about Centmin Mod LEMP Stack today
Become a Member

posting replies error

Discussion in 'Forum Feedback & Suggestions' started by dooma, Jan 17, 2018.

  1. dooma

    dooma Active Member

    299
    31
    28
    Oct 15, 2016
    Cairo
    Ratings:
    +44
    Local Time:
    9:33 PM
    Hello

    I think there's an error with posting replies. Every time my replay was duplicated 2/3 times with Safari on ipad and Chrome on Laptop&PC.

    Thanks
     
  2. eva2000

    eva2000 Administrator Staff Member

    37,354
    8,162
    113
    May 24, 2014
    Brisbane, Australia
    Ratings:
    +12,563
    Local Time:
    5:33 AM
    Nginx 1.15.x
    MariaDB 5.5/10.x
    Yeah it's a problem with one of Xenforo widgets's conditional code for Google Adsense, it's interfering with the ad that shows every 3rd post :(

    Probably need to remove the conditional which hides ads for Premium users for that ad every 3rd post. So means Premium users will see that ad for now.
     
  3. eva2000

    eva2000 Administrator Staff Member

    37,354
    8,162
    113
    May 24, 2014
    Brisbane, Australia
    Ratings:
    +12,563
    Local Time:
    5:33 AM
    Nginx 1.15.x
    MariaDB 5.5/10.x
    Testing 3rd post of this thread

    Confirmed issue is with xenforo conditional which shows adsense ads on 3rd post of forum. If i set it to show on 5th or 7th or 9th, it's always that post that hangs for replying.

    In Xenforo in template ad_message_below i have the following
    Code (Text):
    <xen:if is="{$post.position} % {$xenOptions.messagesPerPage} == 2 AND !{xen:helper ismemberof, $visitor, 5}">
    <div style="padding-top:10px;width:90%;contain: layout style paint;">
    <style>
    .cmres1 { width: 320px; height: 50px; }
    @media(min-width: 500px) { .cmres1 { width: 468px; height: 60px; } }
    @media(min-width: 800px) { .cmres1 { width: 728px; height: 90px; } }
    </style>
    <!-- cmres2 -->
    <ins class="adsbygoogle cmres2"
         style="display:block"
         data-ad-client="ca-pub-6669518204467592"
         data-ad-slot="4024536743"
         data-ad-format="auto"></ins>
    <script>
    (adsbygoogle = window.adsbygoogle || []).push({});
    </script>
    </div>
    </xen:if>
     
    Last edited: Jan 17, 2018
  4. rdan

    rdan Premium Member Premium Member

    4,420
    1,059
    113
    May 25, 2014
    Ratings:
    +1,543
    Local Time:
    3:33 AM
    Mainline
    10.2
    I have fixed this on my board, I disable it from showing when it's the last post of the thread.
     
  5. eva2000

    eva2000 Administrator Staff Member

    37,354
    8,162
    113
    May 24, 2014
    Brisbane, Australia
    Ratings:
    +12,563
    Local Time:
    5:33 AM
    Nginx 1.15.x
    MariaDB 5.5/10.x
    which conditional for that - tried a few and all seem to still result in the hang
     
  6. rdan

    rdan Premium Member Premium Member

    4,420
    1,059
    113
    May 25, 2014
    Ratings:
    +1,543
    Local Time:
    3:33 AM
    Mainline
    10.2
    I show ads after 4th post so my conditional has this:
    Code:
    count({$posts}) > 4
     
  7. eva2000

    eva2000 Administrator Staff Member

    37,354
    8,162
    113
    May 24, 2014
    Brisbane, Australia
    Ratings:
    +12,563
    Local Time:
    5:33 AM
    Nginx 1.15.x
    MariaDB 5.5/10.x
    ah that was it, seems this works - thanks @RoldanLT (y)

    Code (Text):
    <xen:if is="!{xen:helper ismemberof, $visitor, 5}">
    <xen:if is="{$post.position} % {$xenOptions.messagesPerPage} == 2 AND !{$message.conversation_id} AND {$thread.reply_count} > 2">
    <div style="padding-top:10px;width:90%;contain: layout style paint;">
    <style>
    .cmres1 { width: 320px; height: 50px; }
    @media(min-width: 500px) { .cmres1 { width: 468px; height: 60px; } }
    @media(min-width: 800px) { .cmres1 { width: 728px; height: 90px; } }
    </style>
    <!-- cmres2 -->
    <ins class="adsbygoogle cmres2"
         style="display:block"
         data-ad-client="ca-pub-6669518204467592"
         data-ad-slot="4024536743"
         data-ad-format="auto"></ins>
    <script>
    (adsbygoogle = window.adsbygoogle || []).push({});
    </script>
    </div>
    </xen:if>
    </xen:if>
     
  8. dooma

    dooma Active Member

    299
    31
    28
    Oct 15, 2016
    Cairo
    Ratings:
    +44
    Local Time:
    9:33 PM
    Why @eva2000 didn't convert the forums to XF2 till now ?
     
  9. dooma

    dooma Active Member

    299
    31
    28
    Oct 15, 2016
    Cairo
    Ratings:
    +44
    Local Time:
    9:33 PM
    Btw, I'm using woltlab and it is amazing software.
     
  10. eva2000

    eva2000 Administrator Staff Member

    37,354
    8,162
    113
    May 24, 2014
    Brisbane, Australia
    Ratings:
    +12,563
    Local Time:
    5:33 AM
    Nginx 1.15.x
    MariaDB 5.5/10.x
    waiting 6+ months fo XF addon devs to catch up and iron out bugs :D
     
    • Like Like x 1
  11. rdan

    rdan Premium Member Premium Member

    4,420
    1,059
    113
    May 25, 2014
    Ratings:
    +1,543
    Local Time:
    3:33 AM
    Mainline
    10.2
    Will:
    Still work on 2nd,3rd,4th pages?
     
  12. eva2000

    eva2000 Administrator Staff Member

    37,354
    8,162
    113
    May 24, 2014
    Brisbane, Australia
    Ratings:
    +12,563
    Local Time:
    5:33 AM
    Nginx 1.15.x
    MariaDB 5.5/10.x
..