Join the community today
Register Now

Master Branch ngx_pagespeed dynamic module routine update in 123.09beta01

Discussion in 'Centmin Mod Github Commits' started by eva2000, Apr 9, 2017.

  1. eva2000

    eva2000 Administrator Staff Member

    30,947
    6,915
    113
    May 24, 2014
    Brisbane, Australia
    Ratings:
    +10,413
    Local Time:
    8:49 AM
    Nginx 1.13.x
    MariaDB 5.5
    ngx_pagespeed dynamic module routine update in 123.09beta01

    ensure if ngx_pagespeed.so dynamic module and load module line is detected that nginx pagespeed routine doesn't comment out the pagespeedadmin.conf include file in /usr/local/nginx/conf/nginx.conf as outlined issue at https://community.centminmod.com/posts/47781/

    however, outstanding issue now is that centmin mod nginx configuration routine detects if NGINX_PAGESPEED='n' is set so if you just drop in ngx_pagespeed.so dynamic module manually into /usr/local/nginx/modules directory and manually add ngx_pagespeed.so load modules line to /usr/local/nginx/conf/dynamic-modules.conf, on centmin.sh menu option 4 will currently wipe the /usr/local/nginx/conf/dynamic-modules.conf entries and re-populate based on which nginx dynamic module variables are enabled i.e. NGXDYNAMIC_NGXPAGESPEED='y' + NGINX_PAGESPEED='y'.

    So essentially right now each centmin.sh menu option 4 recompile time checks for NGXDYNAMIC_NGXPAGESPEED='y' + NGINX_PAGESPEED='y' before populating /usr/local/nginx/conf/dynamic-modules.conf with the load line for ngx_pagspeed.so and wipes out any instance of ngx_pagespeed.so in /usr/local/nginx/modules when NGINX_PAGESPEED='n' set. So manual drop in of dynamic modules won't work 100% on subsequent centmin.sh menu option 4 recompiles as previously I assume if NGINX_PAGESPEED='n' is set, that you don't want to load ngx_pagespeed.so dynamic module. Will need to come up with some new logic as if you set NGINX_PAGESPEED='n' and NGXDYNAMIC_NGXPAGESPEED='n', normally you'd assume ngx_pagepseed.so isn't wanted.

    Continue reading...

    Centmin Mod Github Master branch

    Master branch is where most recent commits are made as at May 24, 2015.