[Solved] Nginx_brotli error

how did you install nginx_brotli nginx module? did you use these 2 variables in persistent config file at /etc/centminmod/custom_config.inc ?

Code (Text):

NGXDYNAMIC_BROTLI='y'
NGINX_LIBBROTLI='y'

what's contents of your persistent config file at /etc/centminmod/custom_config.inc - mask any sensitive info first

I tried on Almalinux 8 and seems to be working

 

OK thanks will check that out

 

Just tried this on CentOS 7 and it works. Then tried on AlmaLinux 8 and it breaks! I think it might be due to using GCC 11 compiler versus GCC 10 on CentOS 7 for -Werror=vla-parameter marked warnings being treated as errors which previous GCC versions didn't do

Code (Text):

../ngx_brotli/deps/brotli/c/enc/encode.c:1473:20: error: argument 5 of type ‘const uint8_t *’ {aka ‘const unsigned char *’} declared as a pointer [-Werror=vla-parameter]
 1473 |     const uint8_t* input_buffer, size_t* encoded_size,
      |     ~~~~~~~~~~~~~~~^~~~~~~~~~~~
In file included from ../ngx_brotli/deps/brotli/c/enc/encode.c:9:
/usr/local/nginx-dep/include/brotli/encode.h:314:19: note: previously declared as a variable length array ‘const uint8_t[input_size]’ {aka ‘const unsigned char[input_size]’}
  314 |     const uint8_t input_buffer[BROTLI_ARRAY_PARAM(input_size)],
      |     ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../ngx_brotli/deps/brotli/c/enc/encode.c:1474:14: error: argument 7 of type ‘uint8_t *’ {aka ‘unsigned char *’} declared as a pointer [-Werror=vla-parameter]
 1474 |     uint8_t* encoded_buffer) {
      |     ~~~~~~~~~^~~~~~~~~~~~~~
/usr/local/nginx-dep/include/brotli/encode.h:316:13: note: previously declared as a variable length array ‘uint8_t[*encoded_size]’ {aka ‘unsigned char[*encoded_size]’}
  316 |     uint8_t encoded_buffer[BROTLI_ARRAY_PARAM(*encoded_size)]);
      |     ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [objs/Makefile:2019: objs/addon/enc/encode.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/svr-setup/nginx-1.23.2'
make: *** [Makefile:10: build] Error 2

@hson4787In future if you run centmin.sh menu option 4 and recompile nginx version = 1.23.2 with the following set in persistent config file at /etc/centminmod/custom_config.inc

Code (Text):

NGXDYNAMIC_BROTLI='y'
NGINX_LIBBROTLI='y'
NGINX_BROTLIDEP_UPDATE='y'

If it breaks again for whatever reason, to troubleshoot, you need to check the full nginx upgrade log at /root/centminlogs and instructions under Sharing logs and errors heading for using Pastebin.com or Gists to share a sanitised version of the contents of the nginx_upgrade.log log. You can see full details at How to troubleshoot Centmin Mod initial install issues

also what's output of

Code (Text):

nginx -t

when you run centmin.sh menu option 4 there's a nginx upgrade log timestamped at /root/centminlogs

if you type this command it lists all logs in date ascending order so latest log at bottom

Code (Text):

ls -lArt /root/centminlogs

so copy the entire contents of latest nginx_upgrade log to gist.github.com or pastebin.com

you can use grep to filter the logs, i.e. look for nginx_upgrade in log name

Code (Text):

ls -lahrt /root/centminlogs/ | grep nginx_upgrade
-rw-r--r--  1 root root 3.2M Oct 11 15:55 centminmod_1.2.3-eva2000.09.001_111016-155345_nginx_upgrade.log
-rw-r--r--  1 root root 672K Oct 11 22:06 centminmod_1.2.3-eva2000.09.001_111016-220515_nginx_upgrade.log

So the last nginx upgrade log was named centminmod_1.2.3-eva2000.09.001_111016-220515_nginx_upgrade.log and located at /root/centminlogs/centminmod_1.2.3-eva2000.09.001_111016-220515_nginx_upgrade.log

then use cat command to output the contents of that log

clear your ssh window buffer/screen and type

Code (Text):

cat /root/centminlogs/centminmod_1.2.3-eva2000.09.001_111016-220515_nginx_upgrade.log

then select and copy and paste output to pastebin.com or gist.github.com file to share. If your SSH client's scroll buffer isn't large enough using cat might not output the entire log file contents, so you may need to download the log and use local text editor to open and copy and paste.

so only need content of one specific log, in this case most recent nginx_upgrade.log log

Sharing Logs Via Dropbox

You can also share the relevant required log files outlined above via Dropbox send via email feature at https://community.centminmod.com/threads/using-dropbox-to-share-server-files.22327/

 

Confirmed as much working on a fix for this for AlmaLinux 8/EL8+ with GCC 11 and GCC 12 compiled Nginx with nginx_brotli module using persistent config file at /etc/centminmod/custom_config.inc

Code (Text):

NGXDYNAMIC_BROTLI='y'
NGINX_LIBBROTLI='y'
NGINX_BROTLIDEP_UPDATE='y'

Nginx 1.23.2 with GCC 11 on AlmaLinux 8 where br-6e975bc is the Brotli last commit for nginx_brotli

Nginx 1.23.2 with GCC 12 on AlmaLinux 8

The fix hasn't been committed to 130.00beta01 yet so for now don't use
NGINX_BROTLIDEP_UPDATE='y' as it doesn't do much as both nginx_brotli used brotli version 1.0.9 is same as Google Brotli upstream 1.0.9 so there shouldn't be any difference that would require using NGINX_BROTLIDEP_UPDATE='y'