Discover Centmin Mod today
Register Now

Beta Branch fix download and nginx build failure propagation in 140.00beta01

Discussion in 'Centmin Mod Github Commits' started by eva2000, Nov 14, 2026 at 9:34 PM.

  1. eva2000

    eva2000 Administrator Staff Member

    60,407
    12,614
    113
    May 24, 2014
    Brisbane, Australia
    Ratings:
    +19,273
    Local Time:
    11:51 AM
    Nginx 1.31.x
    MariaDB 10.x/11.4+/12.3+
    fix download and nginx build failure propagation in 140.00beta01

    A failed download or nginx build step did not stop centmin.sh. Many
    download functions ended with `exit #$ERROR`, which exits with the status
    of the previous command (0 after checklogdetails), and most callers did
    not check return codes, so an install or a menu 4 nginx upgrade could
    carry on without its sources and still exit 0. This brings over the
    141.00beta01 handling from ac1b0305 and d3aeb14e, and the caller checks
    from 7e672330 and 06f1878b.

    Changes:
    - inc/downloads.inc, inc/zlib.inc, inc/pcre.inc, inc/luajit.inc: return 1
    or exit 1 when a download, extraction or build step fails
    - inc/php_upgrade.inc, inc/zendopcache_reinstall.inc, inc/axelsetup.inc:
    bare exit and `exit #$ERROR` become exit 1
    - inc/nginx_patch.inc: return patch and ngx_devel_kit failures, validate
    the ngx_devel_kit archive directory, build source paths from DIR_TMP,
    use FREENGINX_VERSION for freenginx, and drop --no-check-certificate
    from the TLS patch downloads
    - inc/nginx_backup.inc: return 1 when the nginx conf backup fails
    - inc/nginx_install.inc, inc/nginx_configure.inc: check the PCRE, LuaJIT
    and patch steps
    - centmin.sh, centmin-cli.sh: stop the install when alldownloads,
    source_pcreinstall or ngxinstallmain fails, checking PIPESTATUS after
    the tee blocks
    - inc/mainmenu_cli.inc: return the status of alldownloads,
    funct_centmininstall, funct_nginxupgrade and funct_phpupgrade
    - inc/nginx_upgrade.inc: menu 4 returns 1 when the zlib download, module
    checks, dependency builds, backup, PCRE, LuaJIT or patch steps fail,
    switching NGINX_UPDATEMAINTENANCE maintenance mode off first; exit 1
    when the nginx download or extraction fails
    - tested on AlmaLinux 8 (fresh install) and AlmaLinux 9: normal installs,
    nginx and PHP rebuilds exit 0, forced download failures exit 1 with
    nginx and PHP still serving


    Continue reading...

    140.00beta01 branch