Discover Centmin Mod today
Register Now

Beta Branch disable NGINX_HPACK='n' with nginx 1.13.9

Discussion in 'Centmin Mod Github Commits' started by eva2000, Feb 14, 2018.

  1. eva2000

    eva2000 Administrator Staff Member

    37,720
    8,257
    113
    May 24, 2014
    Brisbane, Australia
    Ratings:
    +12,713
    Local Time:
    10:40 AM
    Nginx 1.15.x
    MariaDB 5.5/10.x
  2. JJC84

    JJC84 Active Member

    182
    76
    28
    Jan 31, 2018
    Ratings:
    +114
    Local Time:
    6:40 PM
    1.15.x
    10.1.x
    Appreciate the heads up!
     
  3. eva2000

    eva2000 Administrator Staff Member

    37,720
    8,257
    113
    May 24, 2014
    Brisbane, Australia
    Ratings:
    +12,713
    Local Time:
    10:40 AM
    Nginx 1.15.x
    MariaDB 5.5/10.x
    • Winner Winner x 1
  4. pamamolf

    pamamolf Premium Member Premium Member

    3,156
    304
    83
    May 31, 2014
    Ratings:
    +547
    Local Time:
    2:40 AM
    Nginx-1.13.x
    MariaDB 10.1.x
    iirc Cloudflare users should auto get that and no need to compile it on the server as they do the same with Brotli :)
     
  5. eva2000

    eva2000 Administrator Staff Member

    37,720
    8,257
    113
    May 24, 2014
    Brisbane, Australia
    Ratings:
    +12,713
    Local Time:
    10:40 AM
    Nginx 1.15.x
    MariaDB 5.5/10.x
    both ngx_brotli and cloudflare hpack have their own variables to set in persistent config file /etc/centminmod/custom_config.inc
    Code (Text):
    NGINX_HPACK='y'
    NGXDYNAMIC_BROTLI=y
    NGINX_LIBBROTLI=y
    


    not enabled by default as they can break on new nginx releases so best to only make it optional for folks willing to deal with and troubleshoot/report such issues.
     
  6. pamamolf

    pamamolf Premium Member Premium Member

    3,156
    304
    83
    May 31, 2014
    Ratings:
    +547
    Local Time:
    2:40 AM
    Nginx-1.13.x
    MariaDB 10.1.x
    What i mean is if you use Cloudflare there is an option at cloudflare panel to enable it and get Brotli without doing anything on the server and when i check using Chrome's dev tool i am able to see there the br :)

    But i am not 100% sure that it is auto automated for Hpack....
     
  7. eva2000

    eva2000 Administrator Staff Member

    37,720
    8,257
    113
    May 24, 2014
    Brisbane, Australia
    Ratings:
    +12,713
    Local Time:
    10:40 AM
    Nginx 1.15.x
    MariaDB 5.5/10.x
    oh you meant Cloudflare's feature offering yes they have enable Brotli button and out of box they offer HTTP/2 HPACK Full Encoding support as users don't need to enable it. Proper HTTP/2 implementation should use HPACK Full Encoding i.e. caddy and h2o and I believe openlitespeed/lietspeed do. But nginx only offers partial HPACK Encoding support hence why Centmin Mod uses Cloudflare's provided patch to add HPACK Full Encoding support to match other web servers' and Cloudflare's HTTP/2 implementation :D
     
    • Informative Informative x 1
..