Nginx [nginx-announce] nginx-1.13.4

eva2000 · Aug 9, 2017

Changes with nginx 1.13.4 08 Aug 2017

*) Feature: the ngx_http_mirror_module.

*) Bugfix: client connections might be dropped during configuration
testing when using the "reuseport" parameter of the "listen"
directive on Linux.

*) Bugfix: request body might not be available in subrequests if it was
saved to a file and proxying was used.

*) Bugfix: cleaning cache based on the "max_size" parameter did not work
on Windows.

*) Bugfix: any shared memory allocation required 4096 bytes on Windows.

*) Bugfix: nginx worker might be terminated abnormally when using the
"zone" directive inside the "upstream" block on Windows.

--
Maxim Dounin
http://nginx.org/
_______________________________________________
nginx-announce mailing list
nginx-announce@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-announce

Continue reading...

Jimmy · Aug 9, 2017

Does not like:

NGINX_PAGESPEED='y'

eva2000 · Aug 9, 2017

Jimmy said: ↑

Does not like:

NGINX_PAGESPEED='y'
Click to expand...

hmm confirmed nginx 1.13.4 broke ngx_pagespeed compatibility - for now stay on 1.13.3 until i investigate

in 123.09beta01, when enabling ngx_pagespeed (disabled by default) via
Code (Text):
NGXDYNAMIC_NGXPAGESPEED='y'
NGINX_PAGESPEED='y'
results in
Code (Text):
objs/ngx_stream_module_modules.o \
-lrt -ljemalloc -Wl,-z,relro -Wl,-rpath,/usr/local/lib \
-shared
../ngx_pagespeed-1.12.34.2-beta/src/ngx_pagespeed.cc: In function ‘ngx_int_t net_instaweb::{anonymous}::ps_preaccess_handler(ngx_http_request_t*)’:
../ngx_pagespeed-1.12.34.2-beta/src/ngx_pagespeed.cc:3011:31: error: ‘ngx_http_core_try_files_phase’ was not declared in this scope
   while (ph[i + 1].checker != ngx_http_core_try_files_phase &&
                               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[1]: *** [objs/addon/src/ngx_pagespeed.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/svr-setup/nginx-1.13.4'
make: *** [build] Error 2
submitted bug report at nginx 1.13.4 ‘ngx_http_core_try_files_phase’ was not declared in this scope · Issue #1451 · pagespeed/ngx_pagespeed · GitHub

update: fixed Nginx - [nginx-announce] nginx-1.13.4

buik · Aug 9, 2017

eva2000 said: ↑

hmm confirmed nginx 1.13.4 broke ngx_pagespeed compatibility3.4
Click to expand...

Pagespeed could be game over.
No release after +-8 months (latest stable is the same beta as of December 2 2016).

Plus the most important thing. There is absolutely no reason to use pagespeed as there are better options to pre- optimize your content.
For example:

Kraken Image Optimizer
MinifyResources

eva2000 · Aug 9, 2017

well i hope not - fingers crossed

on the fly image optimisation and tailored to device mobile vs non-mobile is one of my fav features

last commit was June 28 so not far off Commits · pagespeed/ngx_pagespeed · GitHub

eva2000 · Aug 9, 2017

already got reply from ngx_pagespeed folks in bug report

Thanks for the report. It seems the breaking change was in nginx/nginx@129b06d

Looking at the specifics, it don't think it's going to be hard to address on our side.
Click to expand...

buik · Aug 9, 2017

eva2000 said: ↑

already got reply from ngx_pagespeed folks in bug report
Click to expand...

Otto van der Schaaf is a nice guy.
Props to him for the fast reply.

eva2000 said: ↑

last commit was June 28 so not far off Commits · pagespeed/ngx_pagespeed · GitHub
Click to expand...

Last feature is from January 2017, you wrote about a bug fix as git commit.

eva2000 · Aug 9, 2017

bassie said: ↑

Otto van der Schaaf is a nice guy.
Props to him for the fast reply.
Click to expand...

yup awesome guy

new nginx module added in 1.13.4 is interesting Module ngx_http_mirror_module
The ngx_http_mirror_module module (1.13.4) implements mirroring of an original request by creating background mirror subrequests. The output of mirror subrequests is ignored.
Code (Text):
location / {
   mirror /mirror;
   proxy_pass http://backend;
}

location /mirror {
   internal;
   proxy_pass http://test_backend$request_uri;
}
Click to expand...
could get very creative with this feature

buik · Aug 9, 2017

eva2000 said: ↑

on the fly image optimisation and tailored to device mobile vs non-mobile is one of my fav features
Click to expand...

device mobile vs non-mobile? You are using Pagespeed to determine if the visitor is on mobile or non mobile (desktop) so pagespeed can optimize pictures etc for mobile of desktop?

eva2000 · Aug 9, 2017

bassie said: ↑

device mobile vs non-mobile? You are using Pagespeed to determine if the visitor is on mobile or non mobile (desktop) so pagespeed can optimize pictures etc for mobile of desktop?
Click to expand...

yup i have separate optimised image settings one for desktop and one for mobile so that mobile users get faster loading pages - been doing this for years now with ngx_pagespeed

eva2000 · Aug 9, 2017

for folks not using ngx_pagespeed (which is default disabled in centmin mod), 1.13.4 updates fine via centmin.sh menu option 4

nginx -V
nginx version: nginx/1.13.4
built by clang 3.4.2 (tags/RELEASE_34/dot2-final)
built with LibreSSL 2.5.5
TLS SNI support enabled
configure arguments: --with-ld-opt='-lrt -ljemalloc -Wl,-z,relro -Wl,-rpath,/usr/local/lib' --with-cc-opt='-m64 -mtune=native -DTCP_FASTOPEN=23 -g -O3 -fstack-protector -fuse-ld=gold --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wno-sign-compare -Wno-string-plus-int -Wno-deprecated-declarations -Wno-unused-parameter -Wno-unused-const-variable -Wno-conditional-uninitialized -Wno-mismatched-tags -Wno-sometimes-uninitialized -Wno-parentheses-equality -Wno-tautological-compare -Wno-self-assign -Wno-deprecated-register -Wno-deprecated -Wno-invalid-source-encoding -Wno-pointer-sign -Wno-parentheses -Wno-enum-conversion -Wno-c++11-compat-deprecated-writable-strings -Wno-write-strings -gsplit-dwarf' --sbin-path=/usr/local/sbin/nginx --conf-path=/usr/local/nginx/conf/nginx.conf --with-compat --with-http_stub_status_module --with-http_secure_link_module --with-libatomic --with-http_gzip_static_module --with-http_sub_module --with-http_addition_module --with-http_image_filter_module=dynamic --with-http_geoip_module --with-stream_geoip_module --with-stream_realip_module --with-stream_ssl_preread_module --with-threads --with-stream=dynamic --with-stream_ssl_module --with-http_realip_module --add-dynamic-module=../ngx-fancyindex-0.4.0 --add-module=../ngx_cache_purge-2.3 --add-module=../ngx_devel_kit-0.3.0 --add-module=../set-misc-nginx-module-0.31 --add-module=../echo-nginx-module-0.60 --add-module=../redis2-nginx-module-0.14 --add-module=../ngx_http_redis-0.3.7 --add-module=../memc-nginx-module-0.18 --add-module=../srcache-nginx-module-0.31 --add-module=../headers-more-nginx-module-0.32 --with-pcre=../pcre-8.41 --with-pcre-jit --with-zlib=../zlib-1.2.11 --with-http_ssl_module --with-http_v2_module --with-openssl=../libressl-2.5.5
Click to expand...

Sunka · Aug 9, 2017

yep

[root@upcloud ~]# nginx -V
nginx version: nginx/1.13.4
built by gcc 6.2.1 20160916 (Red Hat 6.2.1-3) (GCC)
built with LibreSSL 2.5.5
TLS SNI support enabled
configure arguments: --with-ld-opt='-lrt -ljemalloc -Wl,-z,relro -Wl,-rpath,/usr/local/lib' --with-cc-opt='-m64 -march=native -DTCP_FASTOPEN=23 -g -O3 -Wno-error=strict-aliasing -fstack-protector-strong -flto -fuse-ld=gold --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wno-deprecated-declarations -gsplit-dwarf' --sbin-path=/usr/local/sbin/nginx --conf-path=/usr/local/nginx/conf/nginx.conf --with-compat --with-http_stub_status_module --with-http_secure_link_module --with-libatomic --with-http_gzip_static_module --add-dynamic-module=../ngx_brotli --with-http_sub_module --with-http_addition_module --with-http_image_filter_module=dynamic --with-http_geoip_module --with-stream_geoip_module --with-stream_realip_module --with-stream_ssl_preread_module --with-threads --with-stream=dynamic --with-stream_ssl_module --with-http_realip_module --add-dynamic-module=../ngx-fancyindex-0.4.0 --add-module=../ngx_cache_purge-2.3 --add-module=../ngx_devel_kit-0.3.0 --add-module=../set-misc-nginx-module-0.31 --add-module=../echo-nginx-module-0.60 --add-module=../redis2-nginx-module-0.14 --add-module=../ngx_http_redis-0.3.7 --add-module=../memc-nginx-module-0.18 --add-module=../srcache-nginx-module-0.31 --add-module=../headers-more-nginx-module-0.32 --with-pcre=../pcre-8.41 --with-pcre-jit --with-zlib=../zlib-1.2.11 --with-http_ssl_module --with-http_v2_module --with-http_v2_hpack_enc --with-openssl=../libressl-2.5.5
Click to expand...

Jimmy · Aug 9, 2017

FYI once you update to 1.13.4 w/ pagespeed and it fails, you can't go back to 1.13.3 and use pagespeed. I tried and got an error with 1.13.3 when I tried to downgrade w/ pagespeed.

rdan · Aug 9, 2017

Jimmy said: ↑

FYI once you update to 1.13.4 w/ pagespeed and it fails, you can't go back to 1.13.3 and use pagespeed. I tried and got an error with 1.13.3 when I tried to downgrade w/ pagespeed.
Click to expand...

Even if you delete all the contents on /svr_setup/* ?

Jimmy · Aug 9, 2017

RoldanLT said: ↑

Even if you delete all the contents on /svr_setup/* ?
Click to expand...

Maybe, I didn't try that. I ended up just commenting out the pagespeed line in the nginx.conf

eva2000 · Aug 9, 2017

Jimmy said: ↑

FYI once you update to 1.13.4 w/ pagespeed and it fails, you can't go back to 1.13.3 and use pagespeed. I tried and got an error with 1.13.3 when I tried to downgrade w/ pagespeed.
Click to expand...

strange worked fine here.

nginx -V
nginx version: nginx/1.13.3
built by gcc 6.2.1 20160916 (Red Hat 6.2.1-3) (GCC)
built with LibreSSL 2.6.0
TLS SNI support enabled
configure arguments: --with-ld-opt='-lrt -ljemalloc -Wl,-z,relro -Wl,-rpath,/usr/local/lib' --with-cc-opt='-m64 -march=native -DTCP_FASTOPEN=23 -g -O3 -Wno-error=strict-aliasing -fstack-protector-strong -flto -fuse-ld=gold --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wno-deprecated-declarations -gsplit-dwarf' --sbin-path=/usr/local/sbin/nginx --conf-path=/usr/local/nginx/conf/nginx.conf --with-compat --with-http_stub_status_module --with-http_secure_link_module --with-libatomic --with-http_gzip_static_module --add-dynamic-module=../ngx_brotli --add-dynamic-module=../ngx_pagespeed-1.12.34.2-beta --with-http_sub_module --with-http_addition_module --with-http_image_filter_module=dynamic --with-http_geoip_module --with-stream_geoip_module --with-stream_realip_module --with-stream_ssl_preread_module --with-threads --with-stream=dynamic --with-stream_ssl_module --with-http_realip_module --add-dynamic-module=../ngx-fancyindex-0.4.0 --add-module=../ngx_cache_purge-2.3 --add-module=../ngx_devel_kit-0.3.0 --add-module=../set-misc-nginx-module-0.31 --add-module=../echo-nginx-module-0.60 --add-module=../redis2-nginx-module-0.14 --add-module=../ngx_http_redis-0.3.7 --add-module=../memc-nginx-module-0.18 --add-module=../srcache-nginx-module-0.31 --add-module=../headers-more-nginx-module-0.32 --with-pcre=../pcre-8.41 --with-pcre-jit --with-zlib=../zlib-1.2.11 --with-http_ssl_module --with-http_v2_module --with-http_v2_hpack_enc --with-openssl=../libressl-2.6.0
Click to expand...

Jimmy · Aug 9, 2017

Oh, you know, now that I think about it, I removed it from the custom_config. That was the issue. So when I downgraded and didn't compile with pagespeed, it gave me an error using 1.13.3 because of the line in the nginx.conf.

eva2000 · Aug 9, 2017

Jimmy said: ↑

Oh, you know, now that I think about it, I removed it from the custom_config. That was the issue. So when I downgraded and didn't compile with pagespeed, it gave me an error using 1.13.3 because of the line in the nginx.conf.
Click to expand...

centmin actual auto detects and disables/enables nginx.conf related pagespeed when you don't set the variables so that shouldn't have happened either

unless you mean you removed nginx.conf related pagespeed options manually?

Jimmy · Aug 9, 2017

I commented out the pagespeed line in the nginx.conf.

I'm off to bed, I'll test it tomorrow and see if what you said it should do happens.

buik · Aug 11, 2017

eva2000 said: ↑

submitted bug report at nginx 1.13.4 ‘ngx_http_core_try_files_phase’ was not declared in this scope · Issue #1451 · pagespeed/ngx_pagespeed · GitHub
Click to expand...

Fixed: nginx 1.13.4: Fix compilation error by oschaaf · Pull Request #1453 · pagespeed/ngx_pagespeed · GitHub
Tip for endusers: patch your code and you're good

Log in / Register

Forums

Join the community today

Nginx [nginx-announce] nginx-1.13.4

eva2000 Administrator Staff Member

Jimmy Well-Known Member

eva2000 Administrator Staff Member

buik “The best traveler is one without a camera.”

eva2000 Administrator Staff Member

eva2000 Administrator Staff Member

buik “The best traveler is one without a camera.”

eva2000 Administrator Staff Member

buik “The best traveler is one without a camera.”

eva2000 Administrator Staff Member

eva2000 Administrator Staff Member

Sunka Well-Known Member

Jimmy Well-Known Member

rdan Well-Known Member

Jimmy Well-Known Member

eva2000 Administrator Staff Member

Jimmy Well-Known Member

eva2000 Administrator Staff Member

Jimmy Well-Known Member

buik “The best traveler is one without a camera.”

.

Log in / Register

Useful Searches

Join the community today

Nginx [nginx-announce] nginx-1.13.4

eva2000 Administrator Staff Member

Jimmy Well-Known Member

eva2000 Administrator Staff Member

buik “The best traveler is one without a camera.”

eva2000 Administrator Staff Member

eva2000 Administrator Staff Member

buik “The best traveler is one without a camera.”

eva2000 Administrator Staff Member

buik “The best traveler is one without a camera.”

eva2000 Administrator Staff Member

eva2000 Administrator Staff Member

Sunka Well-Known Member

Jimmy Well-Known Member

rdan Well-Known Member

Jimmy Well-Known Member

eva2000 Administrator Staff Member

Jimmy Well-Known Member

eva2000 Administrator Staff Member

Jimmy Well-Known Member

buik “The best traveler is one without a camera.”

.