Learn about Centmin Mod LEMP Stack today
Register Now

NGINX_HTTPPUSH='y' is broken in 130.00beta01

Discussion in 'Install & Upgrades or Pre-Install Questions' started by rampage, Feb 2, 2023.

Tags:
  1. rampage

    rampage New Member

    11
    0
    1
    Sep 19, 2016
    Ratings:
    +5
    Local Time:
    9:22 AM
    1.23.3
    Please fill in any relevant information that applies to you:
    • CentOS Version: CentOS 7 64bit
    • Centmin Mod Version Installed: 130.00beta01
    • Nginx Version Installed: 1.23.3
    • PHP Version Installed:
    • MariaDB MySQL Version Installed:
    • When was last time updated Centmin Mod code base ? : updated before doing to nginx compile/upgrade
    • Persistent Config:
      1
    LETSENCRYPT_DETECT='y'
    NGXDYNAMIC_BROTLI='y'
    NGINX_LIBBROTLI='y'
    NGINX_LIBBROTLISTATIC='n'
    NGINX_HTTP3='y'
    NGXDYNAMIC_NGXPAGESPEED='y'
    NGINX_HTTPPUSH='y'
    NGINX_MODSECURITY='y'

    Code:
            ../ngx_brotli/deps/brotli/c/enc/cluster.c
    ../http2-push-nginx-module/src/ngx_http_v2_push_module.c: In function ‘ngx_http_v2_push_already_pushed’:
    ../http2-push-nginx-module/src/ngx_http_v2_push_module.c:608:21: error: ‘ngx_http_v2_connection_t’ {aka ‘struct ngx_http_v2_connection_s’} has no member named ‘push_state’
      608 |     push_state = h2c->push_state;
          |                     ^~
    ../http2-push-nginx-module/src/ngx_http_v2_push_module.c: In function ‘ngx_http_v2_push_mark_as_pushed’:
    ../http2-push-nginx-module/src/ngx_http_v2_push_module.c:641:12: error: ‘ngx_http_v2_connection_t’ {aka ‘struct ngx_http_v2_connection_s’} has no member named ‘push_state’
      641 |     if (h2c->push_state == NULL) {
          |            ^~
    ../http2-push-nginx-module/src/ngx_http_v2_push_module.c:642:12: error: ‘ngx_http_v2_connection_t’ {aka ‘struct ngx_http_v2_connection_s’} has no member named ‘push_state’
      642 |         h2c->push_state = ngx_pcalloc(h2c->pool,
          |            ^~
    ../http2-push-nginx-module/src/ngx_http_v2_push_module.c:645:16: error: ‘ngx_http_v2_connection_t’ {aka ‘struct ngx_http_v2_connection_s’} has no member named ‘push_state’
      645 |         if (h2c->push_state == NULL) {
          |                ^~
    ../http2-push-nginx-module/src/ngx_http_v2_push_module.c:649:12: error: ‘ngx_http_v2_connection_t’ {aka ‘struct ngx_http_v2_connection_s’} has no member named ‘push_state’
      649 |         h2c->push_state->already_pushed =
          |            ^~
    ../http2-push-nginx-module/src/ngx_http_v2_push_module.c:651:16: error: ‘ngx_http_v2_connection_t’ {aka ‘struct ngx_http_v2_connection_s’} has no member named ‘push_state’
      651 |         if (h2c->push_state->already_pushed == NULL) {
          |                ^~
    ../http2-push-nginx-module/src/ngx_http_v2_push_module.c:662:32: error: ‘ngx_http_v2_connection_t’ {aka ‘struct ngx_http_v2_connection_s’} has no member named ‘push_state’
      662 |     pushed = ngx_array_push(h2c->push_state->already_pushed);
          |                                ^~
    ../http2-push-nginx-module/src/ngx_http_v2_push_module.c: In function ‘ngx_http_v2_push_above_max_pushes’:
    ../http2-push-nginx-module/src/ngx_http_v2_push_module.c:680:12: error: ‘ngx_http_v2_connection_t’ {aka ‘struct ngx_http_v2_connection_s’} has no member named ‘push_state’
      680 |     if (h2c->push_state == NULL) {
          |            ^~
    ../http2-push-nginx-module/src/ngx_http_v2_push_module.c:684:15: error: ‘ngx_http_v2_connection_t’ {aka ‘struct ngx_http_v2_connection_s’} has no member named ‘push_state’
      684 |     return h2c->push_state->already_pushed->nelts >= h2pscf->max_pushed_streams;
          |               ^~
    ../http2-push-nginx-module/src/ngx_http_v2_push_module.c: In function ‘ngx_http_v2_push_populate_path’:
    ../http2-push-nginx-module/src/ngx_http_v2_push_module.c:733:32: error: ‘ngx_http_request_t’ {aka ‘struct ngx_http_request_s’} has no member named ‘space_in_uri’; did you mean ‘plus_in_uri’?
      733 |     r->valid_unparsed_uri = r->space_in_uri ? 0 : 1;
          |                                ^~~~~~~~~~~~
          |                                plus_in_uri
    ../http2-push-nginx-module/src/ngx_http_v2_push_module.c: In function ‘ngx_http_v2_push’:
    ../http2-push-nginx-module/src/ngx_http_v2_push_module.c:770:13: error: ‘ngx_http_v2_connection_t’ {aka ‘struct ngx_http_v2_connection_s’} has no member named ‘enable_push’
      770 |     if (!h2c->enable_push || !h2pscf->enable) {
          |             ^~
    ../http2-push-nginx-module/src/ngx_http_v2_push_module.c:782:52: error: ‘ngx_http_v2_connection_t’ {aka ‘struct ngx_http_v2_connection_s’} has no member named ‘next_sid’
      782 |     node = ngx_http_v2_push_get_node_by_id(h2c, h2c->next_sid, 1);
          |                                                    ^~
    ../http2-push-nginx-module/src/ngx_http_v2_push_module.c:793:8: error: ‘ngx_http_v2_connection_t’ {aka ‘struct ngx_http_v2_connection_s’} has no member named ‘next_sid’
      793 |     h2c->next_sid += 2;
          |        ^~
    ../http2-push-nginx-module/src/ngx_http_v2_push_module.c: In function ‘ngx_http_v2_push_above_max_pushes’:
    ../http2-push-nginx-module/src/ngx_http_v2_push_module.c:685:1: error: control reaches end of non-void function [-Werror=return-type]
      685 | }
          | ^
    ../http2-push-nginx-module/src/ngx_http_v2_push_module.c: At top level:
    cc1: note: unrecognized command-line option ‘-Wno-vla-parameter’ may have been intended to silence earlier diagnostics
    cc1: all warnings being treated as errors
    make[1]: *** [objs/addon/src/ngx_http_v2_push_module.o] Error 1
    make[1]: *** Waiting for unfinished jobs....
    make[1]: Leaving directory `/svr-setup/nginx-1.23.3'
    make: *** [build] Error 2
    
    real    0m26.209s
    user    0m35.392s
    sys     0m13.731s
    
    Thu Feb  2 04:16:49 UTC 2023
    Error: 2, Nginx make failed
    


     
  2. rampage

    rampage New Member

    11
    0
    1
    Sep 19, 2016
    Ratings:
    +5
    Local Time:
    9:22 AM
    1.23.3
    maybe this module is no longer needed since Nginx now has native official support for http2 push?
     
  3. eva2000

    eva2000 Administrator Staff Member

    58,893
    12,490
    113
    May 24, 2014
    Brisbane, Australia
    Ratings:
    +19,122
    Local Time:
    9:22 AM
    Nginx 1.31.x
    MariaDB 10.x/11.4+/12.3+
    Indeed it is! NGINX_HTTPPUSH isn't required anymore :) Thanks for the heads up!