Wordpress Cloudflare Polish issues

So I've enabled CF Polish on one of my test subdomains and noticed that Polish wasn't doing it's thing.
After digging around the cmm nginx config files I noticed that all images had the "no-transform" header (in addition to the Vary "accept" header).
Further digging narrowed this down to wpsecure_mydomain.com.conf

I made a couple of tweaks as follows:
- commenting out the no-transform and Vary "Accept" headers
- adding gif to the image list
- extending the expires to 365d (to keep Google Pagespeed Insights happy)

Code:

# WebP extension support if you are converting /uploads images to webp
location ~ ^/wp-content/uploads/ {
  #pagespeed off;
  #pagespeed unplugged;
  #autoindex on;
  #add_header X-Robots-Tag "noindex, nofollow";
  location ~* ^/wp-content/uploads/(.+/)?(.+)\.(gif|png|jpe?g)$ {
    expires 365d;
    #add_header Vary "Accept";
    #add_header Cache-Control "public, no-transform";
    add_header Cache-Control "public";
    try_files $uri$webp_extension $uri =404;
  }
}

CMM version:
123.09beta01.b616

With my tweaks above, webp's are being generated where relevant (and smaller than the original source).

I'm guessing I shouldn't need to do this?
I know CF doesn't support vary and you've got code in place that detects CF - but does that also impact a pro account as per above?

---

 

In my scenario I didn't *think* I had enabled webp serving! How do I disable it and I'll check if I had enabled it at some point.

 

Interesting.
I just did another clean WP install - (I chose Cache Enabler as my caching method) and I didn't install any other plugins and that code block is active by default.
Once again I had to go in and comment out the same 2 lines.

Looking at that code block, it's applying the Vary "accept" and no-transform headers to all jpegs, gifs,pngs (since I have no webp's at all) which I think is the issue.

Does choosing the Cache Enabler cache method via centmin menu options 22 trigger this code block to be activated?

 

that what I was thinking

 

@eva2000 Looks like this bug is still open - want me to create a github issue for it?

 

I sure did, but looking at your commit I see the issue. You'll note at the beginning of this thread that I also commented out
#add_header Vary "Accept";

This is required for CF Polish to work properly:

Source: https://developers.cloudflare.com/images/polish

So not sure how best you could tweak the nginx config at site setup time for the specific use case that webp image serving is completely offloaded to CF/CF Polish?

Sidenote: If I'm an edge case I'm ok doing this manually each time I created a WP site. But I'm sure others might run into this use case and it would be good to let people know they need to comment it out at a minimum if they completely rely on CF Polish for webp serving.