Join the community today
Become a Member

PHP-FPM Anyone with issues logging into Wordpress after upgrading to PHP 7.4.2?

Discussion in 'Install & Upgrades or Pre-Install Questions' started by BamaStangGuy, Jan 24, 2020.

  1. BamaStangGuy

    BamaStangGuy Premium Member Premium Member

    657
    189
    43
    May 25, 2014
    Ratings:
    +265
    Local Time:
    12:56 AM
    If nothing pops up over the next few days with it I will take the time to submit a bug, I just don't have the time to properly do it right now.

     
  2. eva2000

    eva2000 Administrator Staff Member

    47,501
    10,779
    113
    May 24, 2014
    Brisbane, Australia
    Ratings:
    +16,752
    Local Time:
    4:56 PM
    Nginx 1.19.x
    MariaDB 5.5/10.x
    @BamaStangGuy PHP :: Bug #78929 :: plus signs in cookie values are converted to spaces updated notes from some other folks

    wikimedia reported your bug it seems PHP :: Bug #79174 :: setcookie() encodes space as `+`, but $_COOKIE no longer decodes them

    Fix for PHP 7.4.2 is committed at Fix #79174: cookie values with spaces fail to round-trip · php/php-src@addc3c9.

    Updated Centmin Mod 123.09beta01 with properly PHP 7.4.2 fix for cookies just now :)

    cmupdate output
    Code (Text):
    cmupdate
    Saved working directory and index state WIP on 123.09beta01: 1a997c4 update PHP downgrade routine for 5.6 in 123.09beta01
    HEAD is now at 1a997c4 update PHP downgrade routine for 5.6 in 123.09beta01
    Updating 1a997c4..cb6e345
    Fast-forward
     centmin.sh                     |  2 +-
     inc/php_patch.inc              | 23 +++++++++++++++++++++++
     patches/php/php742-79174.patch | 52 ++++++++++++++++++++++++++++++++++++++++++++++++++++
     3 files changed, 76 insertions(+), 1 deletion(-)
     create mode 100644 patches/php/php742-79174.patch
    

    then after running cmupdate, run centmin.sh menu option 5 and specify update to PHP 7.4.2 for recompile if you are using PHP 7.4.0 to 7.4.2

    after centmin.sh menu option 5 update/recompile of PHP 7.4.2 inspecting php patch log
    Code (Text):
    ls -lahrt /root/centminlogs/ | grep patch_php | tail -1
    -rw-rw-r--   1 root root  302 Jan 29 04:34 patch_php_290120-043335.log
    

    Code (Text):
    cat /root/centminlogs/patch_php_290120-043335.log
    patching PHP 7.4.2 for bug #79174
    https://bugs.php.net/bug.php?id=79174
    dos2unix: converting file php742-79174.patch to Unix format ...
    patching file NEWS
    Hunk #1 succeeded at 59 with fuzz 2 (offset 50 lines).
    patching file ext/standard/head.c
    patching file ext/standard/tests/network/setcookie.phpt
    
     
    Last edited: Jan 29, 2020
  3. BamaStangGuy

    BamaStangGuy Premium Member Premium Member

    657
    189
    43
    May 25, 2014
    Ratings:
    +265
    Local Time:
    12:56 AM
    If I applied this patch and recompiled PHP, do I need to do anything different to remove the patch when recompiling in the future?
     
  4. BamaStangGuy

    BamaStangGuy Premium Member Premium Member

    657
    189
    43
    May 25, 2014
    Ratings:
    +265
    Local Time:
    12:56 AM
    If I applied this patch and recompiled PHP, do I need to do anything different to remove the patch when recompiling in the future?
     
  5. eva2000

    eva2000 Administrator Staff Member

    47,501
    10,779
    113
    May 24, 2014
    Brisbane, Australia
    Ratings:
    +16,752
    Local Time:
    4:56 PM
    Nginx 1.19.x
    MariaDB 5.5/10.x
    no need to do anything besides run once the cmupdate command before centmin.sh menu option 5 for the revised PHP 7.4.2 patch for the cookie bug or 7.4.3+