PHP-FPM Anyone with issues logging into Wordpress after upgrading to PHP 7.4.2?

BamaStangGuy · Jan 26, 2020

If nothing pops up over the next few days with it I will take the time to submit a bug, I just don't have the time to properly do it right now.

eva2000 · Jan 29, 2020

eva2000 said: ↑

if they fix at PHP :: Bug #78929 :: plus signs in cookie values are converted to spaces and in PHP 7.4.2 does cause your wordpress site to have issues with logins, probably need to lodge a php.net bug report
Click to expand...

@BamaStangGuy PHP :: Bug #78929 :: plus signs in cookie values are converted to spaces updated notes from some other folks

[2020-01-28 14:23 UTC] steve at vtsv dot ca
While this change fixes the case when using setrawcookie() with data containing a plus sign, it breaks the case when using setcookie() with data containing a space, as setcookie() will url encode the data, turning the space into a plus. The plus no longer gets converted back to a space, and so any validation will fail.

cmb@php.net
Steve, see bug #79174.
Click to expand...

wikimedia reported your bug it seems PHP :: Bug #79174 :: setcookie() encodes space as `+`, but $_COOKIE no longer decodes them

Description:
------------
208.43.231.11 Git - php-src.git/commit fixed #78929 by changing the cookie decoding logic to use php_raw_url_decode() rather than php_url_decode(). Unfortunately, it didn't change php_setcookie() to match.

This results in cookie values with spaces failing to round-trip.

Test script:
---------------
You already have a test illustrating this behavior at 208.43.231.11 Git - php-src.git/blob - ext/standard/tests/network/setcookie.phpt

See lines 10 and 27.
Click to expand...

The fix for this bug has been committed.
If you are still experiencing this bug, try to check out latest source from php/php-src and re-test.
Thank you for the report, and for helping us make PHP better.
Click to expand...

Fix for PHP 7.4.2 is committed at Fix #79174: cookie values with spaces fail to round-trip · php/php-src@addc3c9.

Updated Centmin Mod 123.09beta01 with properly PHP 7.4.2 fix for cookies just now

cmupdate output
Code (Text):
cmupdate
Saved working directory and index state WIP on 123.09beta01: 1a997c4 update PHP downgrade routine for 5.6 in 123.09beta01
HEAD is now at 1a997c4 update PHP downgrade routine for 5.6 in 123.09beta01
Updating 1a997c4..cb6e345
Fast-forward
 centmin.sh                     |  2 +-
 inc/php_patch.inc              | 23 +++++++++++++++++++++++
 patches/php/php742-79174.patch | 52 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 76 insertions(+), 1 deletion(-)
 create mode 100644 patches/php/php742-79174.patch
then after running cmupdate, run centmin.sh menu option 5 and specify update to PHP 7.4.2 for recompile if you are using PHP 7.4.0 to 7.4.2

after centmin.sh menu option 5 update/recompile of PHP 7.4.2 inspecting php patch log
Code (Text):
ls -lahrt /root/centminlogs/ | grep patch_php | tail -1
-rw-rw-r--   1 root root  302 Jan 29 04:34 patch_php_290120-043335.log
Code (Text):
cat /root/centminlogs/patch_php_290120-043335.log
patching PHP 7.4.2 for bug #79174
https://bugs.php.net/bug.php?id=79174
dos2unix: converting file php742-79174.patch to Unix format ...
patching file NEWS
Hunk #1 succeeded at 59 with fuzz 2 (offset 50 lines).
patching file ext/standard/head.c
patching file ext/standard/tests/network/setcookie.phpt

BamaStangGuy · Jan 30, 2020

eva2000 said: ↑
@BamaStangGuy try this manual patch/reverting of main/php_variables.c to the PHP 7.4.1 version to see if PHP 7.4.2 update works for wordpress logins

update local centmin mod 123.09beta01 code to latest via cmupdate command

use cmdir alias command to change to /usr/local/src/centminmod directory where centmin mod code is installed

download via wget cmm-php742-cookie.patch patch file to patch /usr/local/src/centminmod/inc/php_patch.inc include routine which will only patch revert main/php_variables.c file from PHP 7.4.2 version to PHP 7.4.1 version when PHP 7.4.2 detected on centmin.sh menu option 5 upgrade routines. This reverts the PHP 7.4.2 fix for bug #78929 php/php-src

run patch to patch inc/php_patch.inc
Code (Text):
cmupdate
cmdir
wget -O cmm-php742-cookie.patch https://gist.github.com/centminmod/220cfa7e5e786474e40714c7f9371f86/raw/cmm-php742-cookie.patch
patch -p1 < cmm-php742-cookie.patch
run centmin.sh menu option 5 to update to PHP 7.4.2
Code (Text):
centmin
after exiting centmin.sh from php update run command to find PHP patch file log which records every PHP patch applied during centmin.sh menu option 5 runs
Code (Text):
ls -lahrt /root/centminlogs/ | grep patch_php | tail -1
example output
Code (Text):
ls -lahrt /root/centminlogs/ | grep patch_php | tail -1
-rw-r--r--   1 root root  653 Jan 24 23:53 patch_php_240120-235235.log
contents of /root/centminlogs/patch_php_240120-235235.log via command
Code (Text):
cat /root/centminlogs/patch_php_240120-235235.log
Code (Text):
revert PHP 7.4.2 main/php_variables.c to PHP 7.4.1 version
https://community.centminmod.com/posts/81184/
--2020-01-24 23:53:09--  https://raw.githubusercontent.com/php/php-src/PHP-7.4.1/main/php_variables.c
Resolving raw.githubusercontent.com... 151.101.0.133, 151.101.64.133, 151.101.128.133, ...
Connecting to raw.githubusercontent.com|151.101.0.133|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 25713 (25K) [text/plain]
Saving to: ‘main/php_variables.c’

    0K .......... .......... .....                           100% 1.85M=0.01s

2020-01-24 23:53:10 (1.85 MB/s) - ‘main/php_variables.c’ saved [25713/25713]
Click to expand...
If I applied this patch and recompiled PHP, do I need to do anything different to remove the patch when recompiling in the future?

BamaStangGuy · Jan 30, 2020

eva2000 said: ↑
@BamaStangGuy try this manual patch/reverting of main/php_variables.c to the PHP 7.4.1 version to see if PHP 7.4.2 update works for wordpress logins

update local centmin mod 123.09beta01 code to latest via cmupdate command

use cmdir alias command to change to /usr/local/src/centminmod directory where centmin mod code is installed

download via wget cmm-php742-cookie.patch patch file to patch /usr/local/src/centminmod/inc/php_patch.inc include routine which will only patch revert main/php_variables.c file from PHP 7.4.2 version to PHP 7.4.1 version when PHP 7.4.2 detected on centmin.sh menu option 5 upgrade routines. This reverts the PHP 7.4.2 fix for bug #78929 php/php-src

run patch to patch inc/php_patch.inc
Code (Text):
cmupdate
cmdir
wget -O cmm-php742-cookie.patch https://gist.github.com/centminmod/220cfa7e5e786474e40714c7f9371f86/raw/cmm-php742-cookie.patch
patch -p1 < cmm-php742-cookie.patch
run centmin.sh menu option 5 to update to PHP 7.4.2
Code (Text):
centmin
after exiting centmin.sh from php update run command to find PHP patch file log which records every PHP patch applied during centmin.sh menu option 5 runs
Code (Text):
ls -lahrt /root/centminlogs/ | grep patch_php | tail -1
example output
Code (Text):
ls -lahrt /root/centminlogs/ | grep patch_php | tail -1
-rw-r--r--   1 root root  653 Jan 24 23:53 patch_php_240120-235235.log
contents of /root/centminlogs/patch_php_240120-235235.log via command
Code (Text):
cat /root/centminlogs/patch_php_240120-235235.log
Code (Text):
revert PHP 7.4.2 main/php_variables.c to PHP 7.4.1 version
https://community.centminmod.com/posts/81184/
--2020-01-24 23:53:09--  https://raw.githubusercontent.com/php/php-src/PHP-7.4.1/main/php_variables.c
Resolving raw.githubusercontent.com... 151.101.0.133, 151.101.64.133, 151.101.128.133, ...
Connecting to raw.githubusercontent.com|151.101.0.133|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 25713 (25K) [text/plain]
Saving to: ‘main/php_variables.c’

    0K .......... .......... .....                           100% 1.85M=0.01s

2020-01-24 23:53:10 (1.85 MB/s) - ‘main/php_variables.c’ saved [25713/25713]
Click to expand...
If I applied this patch and recompiled PHP, do I need to do anything different to remove the patch when recompiling in the future?

eva2000 · Jan 30, 2020

BamaStangGuy said: ↑

If I applied this patch and recompiled PHP, do I need to do anything different to remove the patch when recompiling in the future?
Click to expand...

no need to do anything besides run once the cmupdate command before centmin.sh menu option 5 for the revised PHP 7.4.2 patch for the cookie bug or 7.4.3+

Log in / Register

Forums

Learn about Centmin Mod LEMP Stack today

PHP-FPM Anyone with issues logging into Wordpress after upgrading to PHP 7.4.2?

BamaStangGuy Active Member

eva2000 Administrator Staff Member

BamaStangGuy Active Member

BamaStangGuy Active Member

eva2000 Administrator Staff Member

.

Log in / Register

Useful Searches

Learn about Centmin Mod LEMP Stack today

PHP-FPM Anyone with issues logging into Wordpress after upgrading to PHP 7.4.2?

BamaStangGuy Active Member

eva2000 Administrator Staff Member

BamaStangGuy Active Member

BamaStangGuy Active Member

eva2000 Administrator Staff Member

.